Apply for Moroccan citizenship or remain a foreigner?

I'm not sure if there is such a thing as citizenship for foreigners in Morocco. Usually you apply for a Carte Sejour/Carte Residence if you want to live here.
For your kids it might be different. If their mother is Moroccan they could get a passport here. So they don't need the residence and can stay as long as they want.
Me personally I don't see why having two nationalities is a con. I would have it on the pro column.
Good luck with your decision!

Thanks.

Cons for having dual nationality might include:
- some countries require declaring this and may view the Moroccan nationality negatively
-  the UK will not help dual nationals in the country of the other nationality
- you no longer benefit as a foreigner in Morocco (what are the benefits?)

Did you do some research if it would be even possible for you or your kids to get a moroccan passport?
As I said, for you I guess not, for your kids you could get both and let them decide themselves after they reach age of consent what to with it. There is no military service so don't worry for that.
I don't see why it should be negative having UK passport plus moroccan nationality. They are moroccan anyway by genes.

Me personally I don’t think  u need to apply for Moroccan cotizenship, u can get residency so easily given the fact that ur spouse is Moroccan, no need for that !! Good luck

Thank you all for your advice and good wishes.

Given that it's not easy to undo/reverse, I think we'll delay the decision until we're on the ground and gain a better feel of the pros and cons and will hopefully share our experience.